ci-operator/step-registry/gather/extra: Add terminal wait #8138
Conversation
Missing from the script since it landed in 23ca2ce (Bootstrap step registry with IPI steps, 2019-11-17, openshift#5962). We need the wait to drain out the queue before the container exits. The bare 'wait' (with no arguments) means we always exit 0, but this log gathering is already not caring about errors, so that's not a functional change.
openshift-ci-robot
added
the
approved
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
Missing from the script since it landed in 23ca2ce (#5962). We need the
waitto drain out the queue before the container exits. The barewait(with no arguments) means we always exit 0, but this log gathering is already not caring about errors, so that's not a functional change.